-
Notifications
You must be signed in to change notification settings - Fork 20
Adding new prop-types library #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
@@ -77,6 +77,7 @@ | |||
"in-publish": "^2.0.0", | |||
"jsdom": "^9.12.0", | |||
"nyc": "^6.4.0", | |||
"prop-types": "^15.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a dependency
@frostney Can we get this merged? |
I also need this in my project, so please merge this. :) ping @frostney |
@frostney Are you able to merge this? If you'd like, I can help manage this project so that we can keep up on top of PRs and issues. |
Please merge this |
I agree, it doesn't work without this pull request. Please merge this. |
If you want to still use this library (@frostney it's BROKEN) use the following command:
I get a different error message now (sigh), but at least the library itself is loading correctly. |
Ok, whatever. It didn't work (at all) in my project and I needed it so I just did the changes myself. I opened a pull request (#13) to merge these changes into this repository, but if you can't wait for that (like me), you can do
and get going :-) |
I did the same 😄 |
Apologies, I haven't had as much for open-source the past year as I'd like to have. Thank you so much for your efforts. ❤️ |
P.S.: I'm totally open to add people as collaborators. Please let me know if anyone is interested. |
This has been published as |
@frostney 👏 Thanks |
React has deprecated PropTypes from the base library and created a separate package,
prop-types
. As of v 15.5 of React, PropTypes has been completely removed. (See here)Also bumping the minimum versions of
react
andreact-dom
per the documentation