Skip to content

Adding new prop-types library #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Conversation

dusave
Copy link

@dusave dusave commented Nov 7, 2017

React has deprecated PropTypes from the base library and created a separate package, prop-types. As of v 15.5 of React, PropTypes has been completely removed. (See here)

Also bumping the minimum versions of react and react-dom per the documentation

package.json Outdated
@@ -77,6 +77,7 @@
"in-publish": "^2.0.0",
"jsdom": "^9.12.0",
"nyc": "^6.4.0",
"prop-types": "^15.6.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a dependency

@dusave
Copy link
Author

dusave commented Nov 16, 2017

@frostney Can we get this merged?

@kristerkari
Copy link

I also need this in my project, so please merge this. :)

ping @frostney

@dusave
Copy link
Author

dusave commented Dec 1, 2017

@frostney Are you able to merge this? If you'd like, I can help manage this project so that we can keep up on top of PRs and issues.

@serhiipalash
Copy link
Collaborator

Please merge this

@infostreams
Copy link

I agree, it doesn't work without this pull request. Please merge this.

@infostreams
Copy link

If you want to still use this library (@frostney it's BROKEN) use the following command:

npm install git://github.com/changbenny/react-intl-native.git\#prop-types --save

I get a different error message now (sigh), but at least the library itself is loading correctly.

@infostreams
Copy link

Ok, whatever. It didn't work (at all) in my project and I needed it so I just did the changes myself. I opened a pull request (#13) to merge these changes into this repository, but if you can't wait for that (like me), you can do

npm install --save git://github.com/infostreams/react-intl-native.git

and get going :-)

@serhiipalash
Copy link
Collaborator

serhiipalash commented Jan 9, 2018

so I just did the changes myself

I did the same 😄
I guess soon we will create our own package to fix issues of this one )

@frostney
Copy link
Owner

Apologies, I haven't had as much for open-source the past year as I'd like to have. Thank you so much for your efforts. ❤️
I'll cut a release today.

@frostney
Copy link
Owner

P.S.: I'm totally open to add people as collaborators. Please let me know if anyone is interested.

@frostney frostney merged commit 0c8b883 into frostney:master Jan 10, 2018
@frostney
Copy link
Owner

This has been published as 2.1.2. Thank you again @dustinsavery and @enterline

@dusave
Copy link
Author

dusave commented Jan 10, 2018

@frostney 👏 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants